diff --git a/src/android/app/src/main/java/org/citra/citra_emu/features/settings/model/Settings.kt b/src/android/app/src/main/java/org/citra/citra_emu/features/settings/model/Settings.kt index 5ecce6dc4..6e97786cd 100644 --- a/src/android/app/src/main/java/org/citra/citra_emu/features/settings/model/Settings.kt +++ b/src/android/app/src/main/java/org/citra/citra_emu/features/settings/model/Settings.kt @@ -165,9 +165,11 @@ class Settings { KEY_CSTICK_AXIS_VERTICAL, KEY_CSTICK_AXIS_HORIZONTAL ) - val dPadKeys = listOf( -// KEY_DPAD_AXIS_VERTICAL, -// KEY_DPAD_AXIS_HORIZONTAL, + val dPadAxisKeys = listOf( + KEY_DPAD_AXIS_VERTICAL, + KEY_DPAD_AXIS_HORIZONTAL + ) + val dPadButtonKeys = listOf( KEY_BUTTON_UP, KEY_BUTTON_DOWN, KEY_BUTTON_LEFT, diff --git a/src/android/app/src/main/java/org/citra/citra_emu/features/settings/model/view/InputBindingSetting.kt b/src/android/app/src/main/java/org/citra/citra_emu/features/settings/model/view/InputBindingSetting.kt index 967b81a8d..c89f002e1 100644 --- a/src/android/app/src/main/java/org/citra/citra_emu/features/settings/model/view/InputBindingSetting.kt +++ b/src/android/app/src/main/java/org/citra/citra_emu/features/settings/model/view/InputBindingSetting.kt @@ -136,7 +136,6 @@ class InputBindingSetting( Settings.KEY_BUTTON_DOWN -> NativeLibrary.ButtonType.DPAD_DOWN Settings.KEY_BUTTON_LEFT -> NativeLibrary.ButtonType.DPAD_LEFT Settings.KEY_BUTTON_RIGHT -> NativeLibrary.ButtonType.DPAD_RIGHT - Settings.HOTKEY_SCREEN_SWAP -> Hotkey.SWAP_SCREEN.button Settings.HOTKEY_CYCLE_LAYOUT -> Hotkey.CYCLE_LAYOUT.button Settings.HOTKEY_CLOSE_GAME -> Hotkey.CLOSE_GAME.button diff --git a/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsActivity.kt b/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsActivity.kt index 18b708131..66e4bcace 100644 --- a/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsActivity.kt +++ b/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsActivity.kt @@ -191,7 +191,7 @@ class SettingsActivity : AppCompatActivity(), SettingsActivityView { presenter.onSettingsReset() val controllerKeys = Settings.buttonKeys + Settings.circlePadKeys + Settings.cStickKeys + - Settings.dPadKeys + Settings.triggerKeys + Settings.dPadButtonKeys + Settings.dPadAxisKeys + Settings.triggerKeys val editor = PreferenceManager.getDefaultSharedPreferences(CitraApplication.appContext).edit() controllerKeys.forEach { editor.remove(it) } diff --git a/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsFragmentPresenter.kt b/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsFragmentPresenter.kt index 5b462b69a..6b643dc16 100644 --- a/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsFragmentPresenter.kt +++ b/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsFragmentPresenter.kt @@ -621,8 +621,13 @@ class SettingsFragmentPresenter(private val fragmentView: SettingsFragmentView) add(InputBindingSetting(button, Settings.axisTitles[i])) } - add(HeaderSetting(R.string.controller_dpad)) - Settings.dPadKeys.forEachIndexed { i: Int, key: String -> + add(HeaderSetting(R.string.controller_dpad_axis)) + Settings.dPadAxisKeys.forEachIndexed { i: Int, key: String -> + val button = getInputObject(key) + add(InputBindingSetting(button, Settings.axisTitles[i])) + } + add(HeaderSetting(R.string.controller_dpad_button)) + Settings.dPadButtonKeys.forEachIndexed { i: Int, key: String -> val button = getInputObject(key) add(InputBindingSetting(button, Settings.dPadTitles[i])) } diff --git a/src/android/app/src/main/res/values/strings.xml b/src/android/app/src/main/res/values/strings.xml index 6acc9d463..9895e45d4 100644 --- a/src/android/app/src/main/res/values/strings.xml +++ b/src/android/app/src/main/res/values/strings.xml @@ -108,6 +108,8 @@ Triggers Trigger D-Pad + D-Pad (Axis) + D-Pad (Buttons) Up/Down Axis Left/Right Axis Up