Forks/citra
1
0
Fork 0
mirror of https://github.com/PabloMK7/citra.git synced 2025-10-31 05:40:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

dyncom: Pass SVC immediates directly.

Browse source 
Previously it would just re-read the already decoded instruction and extract the immediate value.
This commit is contained in:
Lioncash 2015-07-21 03:51:36 -04:00
parent baba0efcd1
commit c2689b8c2c
3 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/core/arm/dyncom/arm_dyncom_interpreter.cpp
View file

@ -6248,7 +6248,8 @@ unsigned InterpreterMainLoop(ARMul_State* cpu) {
SWI_INST: SWI_INST:
{ {
if (inst_base->cond == 0xE || CondPassed(cpu, inst_base->cond)) { if (inst_base->cond == 0xE || CondPassed(cpu, inst_base->cond)) {
SVC::CallSVC(Memory::Read32(cpu->Reg[15])); swi_inst* const inst_cream = (swi_inst*)inst_base->component;
SVC::CallSVC(inst_cream->num & 0xFFFF);
} }
cpu->Reg[15] += GET_INST_SIZE(cpu); cpu->Reg[15] += GET_INST_SIZE(cpu);

7
src/core/hle/svc.cpp
View file

@ -833,8 +833,7 @@ static const FunctionDef SVC_Table[] = {
Common::Profiling::TimingCategory profiler_svc("SVC Calls"); Common::Profiling::TimingCategory profiler_svc("SVC Calls");
static const FunctionDef* GetSVCInfo(u32 opcode) { static const FunctionDef* GetSVCInfo(u32 func_num) {
u32 func_num = opcode & 0xFFFFFF; // 8 bits
if (func_num >= ARRAY_SIZE(SVC_Table)) { if (func_num >= ARRAY_SIZE(SVC_Table)) {
LOG_ERROR(Kernel_SVC, "unknown svc=0x%02X", func_num); LOG_ERROR(Kernel_SVC, "unknown svc=0x%02X", func_num);
return nullptr; return nullptr;
@ -842,10 +841,10 @@ static const FunctionDef* GetSVCInfo(u32 opcode) {
return &SVC_Table[func_num]; return &SVC_Table[func_num];
} }
void CallSVC(u32 opcode) { void CallSVC(u32 immediate) {
Common::Profiling::ScopeTimer timer_svc(profiler_svc); Common::Profiling::ScopeTimer timer_svc(profiler_svc);
const FunctionDef *info = GetSVCInfo(opcode); const FunctionDef* info = GetSVCInfo(immediate);
if (info) { if (info) {
if (info->func) { if (info->func) {
info->func(); info->func();

2
src/core/hle/svc.h
View file

@ -41,6 +41,6 @@ enum ArbitrationType {
namespace SVC { namespace SVC {
void CallSVC(u32 opcode); void CallSVC(u32 immediate);
} // namespace } // namespace