Forks/citra
1
0
Fork 0
mirror of https://github.com/PabloMK7/citra.git synced 2025-10-30 21:30:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix buffer overflow comments

Browse source
This commit is contained in:
polaris- 2015-10-21 06:49:49 -04:00
parent 2b7316a379
commit 9f66580d7e
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/core/gdbstub/gdbstub.cpp
View file

@ -306,6 +306,7 @@ static void SendReply(const char* reply) {
command_length = strlen(reply); command_length = strlen(reply);
if (command_length + 4 > sizeof(command_buffer)) { if (command_length + 4 > sizeof(command_buffer)) {
LOG_ERROR(Debug_GDBStub, "command_buffer overflow in SendReply"); LOG_ERROR(Debug_GDBStub, "command_buffer overflow in SendReply");
return;
} }
memcpy(command_buffer + 1, reply, command_length); memcpy(command_buffer + 1, reply, command_length);
@ -403,12 +404,12 @@ static void ReadCommand() {
} }
while ((c = ReadByte()) != GDB_STUB_END) { while ((c = ReadByte()) != GDB_STUB_END) {
command_buffer[command_length++] = c; if (command_length >= sizeof(command_buffer)) {
if (command_length == sizeof(command_buffer)) {
LOG_ERROR(Debug_GDBStub, "gdb: command_buffer overflow\n"); LOG_ERROR(Debug_GDBStub, "gdb: command_buffer overflow\n");
SendPacket(GDB_STUB_NACK); SendPacket(GDB_STUB_NACK);
return; return;
} }
command_buffer[command_length++] = c;
} }
u8 checksum_received = HexCharToValue(ReadByte()) << 4; u8 checksum_received = HexCharToValue(ReadByte()) << 4;