mirror of
				https://github.com/PabloMK7/citra.git
				synced 2025-10-31 13:50:03 +00:00 
			
		
		
		
	Review comments -part 4
This commit is contained in:
		
							parent
							
								
									08793a6dae
								
							
						
					
					
						commit
						9901b289b6
					
				
					 4 changed files with 7 additions and 9 deletions
				
			
		|  | @ -255,13 +255,6 @@ if (ENABLE_QT) | ||||||
|     endif() |     endif() | ||||||
| endif() | endif() | ||||||
| 
 | 
 | ||||||
| if (ENABLE_WEB_SERVICE) |  | ||||||
|     add_definitions(-DENABLE_WEB_SERVICE) |  | ||||||
| endif() |  | ||||||
| if (CITRA_ENABLE_COMPATIBILITY_REPORTING) |  | ||||||
|     add_definitions(-DCITRA_ENABLE_COMPATIBILITY_REPORTING) |  | ||||||
| endif() |  | ||||||
| 
 |  | ||||||
| if (ENABLE_SCRIPTING) | if (ENABLE_SCRIPTING) | ||||||
|     add_definitions(-DENABLE_SCRIPTING) |     add_definitions(-DENABLE_SCRIPTING) | ||||||
| endif() | endif() | ||||||
|  |  | ||||||
|  | @ -208,6 +208,10 @@ target_link_libraries(citra-qt PRIVATE audio_core common core input_common netwo | ||||||
| target_link_libraries(citra-qt PRIVATE Boost::boost glad nihstro-headers Qt5::OpenGL Qt5::Widgets Qt5::Multimedia) | target_link_libraries(citra-qt PRIVATE Boost::boost glad nihstro-headers Qt5::OpenGL Qt5::Widgets Qt5::Multimedia) | ||||||
| target_link_libraries(citra-qt PRIVATE ${PLATFORM_LIBRARIES} Threads::Threads) | target_link_libraries(citra-qt PRIVATE ${PLATFORM_LIBRARIES} Threads::Threads) | ||||||
| 
 | 
 | ||||||
|  | if (CITRA_ENABLE_COMPATIBILITY_REPORTING) | ||||||
|  |     add_definitions(-DCITRA_ENABLE_COMPATIBILITY_REPORTING) | ||||||
|  | endif() | ||||||
|  | 
 | ||||||
| if (USE_DISCORD_PRESENCE) | if (USE_DISCORD_PRESENCE) | ||||||
|     target_sources(citra-qt PUBLIC |     target_sources(citra-qt PUBLIC | ||||||
|         discord_impl.cpp |         discord_impl.cpp | ||||||
|  |  | ||||||
|  | @ -445,6 +445,7 @@ create_target_directory_groups(core) | ||||||
| target_link_libraries(core PUBLIC common PRIVATE audio_core network video_core) | target_link_libraries(core PUBLIC common PRIVATE audio_core network video_core) | ||||||
| target_link_libraries(core PUBLIC Boost::boost PRIVATE cryptopp fmt open_source_archives) | target_link_libraries(core PUBLIC Boost::boost PRIVATE cryptopp fmt open_source_archives) | ||||||
| if (ENABLE_WEB_SERVICE) | if (ENABLE_WEB_SERVICE) | ||||||
|  |     add_definitions(-DENABLE_WEB_SERVICE) | ||||||
|     target_link_libraries(core PUBLIC json-headers web_service) |     target_link_libraries(core PUBLIC json-headers web_service) | ||||||
| endif() | endif() | ||||||
| 
 | 
 | ||||||
|  |  | ||||||
|  | @ -13,7 +13,7 @@ | ||||||
| 
 | 
 | ||||||
| namespace WebService { | namespace WebService { | ||||||
| 
 | 
 | ||||||
| constexpr char API_VERSION[]{"1"}; | constexpr std::array<const char, 1> API_VERSION{'1'}; | ||||||
| 
 | 
 | ||||||
| constexpr u32 HTTP_PORT = 80; | constexpr u32 HTTP_PORT = 80; | ||||||
| constexpr u32 HTTPS_PORT = 443; | constexpr u32 HTTPS_PORT = 443; | ||||||
|  | @ -70,7 +70,7 @@ Common::WebResult Client::GenericJson(const std::string& method, const std::stri | ||||||
|         }; |         }; | ||||||
|     } |     } | ||||||
| 
 | 
 | ||||||
|     params.emplace(std::string("api-version"), std::string(API_VERSION)); |     params.emplace(std::string("api-version"), std::string(API_VERSION.begin(), API_VERSION.end())); | ||||||
|     if (method != "GET") { |     if (method != "GET") { | ||||||
|         params.emplace(std::string("Content-Type"), std::string("application/json")); |         params.emplace(std::string("Content-Type"), std::string("application/json")); | ||||||
|     }; |     }; | ||||||
|  |  | ||||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue