From 8f25ac55fbea483ce40383e9fa561e2839fdc54e Mon Sep 17 00:00:00 2001 From: Jugurta <74503778+i0x404@users.noreply.github.com> Date: Thu, 22 Aug 2024 12:57:17 +0000 Subject: [PATCH] add requested refactoring --- src/video_core/renderer_vulkan/vk_stream_buffer.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/video_core/renderer_vulkan/vk_stream_buffer.cpp b/src/video_core/renderer_vulkan/vk_stream_buffer.cpp index 468caf934..735fc34b9 100644 --- a/src/video_core/renderer_vulkan/vk_stream_buffer.cpp +++ b/src/video_core/renderer_vulkan/vk_stream_buffer.cpp @@ -33,9 +33,11 @@ vk::MemoryPropertyFlags MakePropertyFlags(BufferType type) { case BufferType::Upload: return vk::MemoryPropertyFlagBits::eHostVisible | vk::MemoryPropertyFlagBits::eHostCoherent; case BufferType::Download: - return vk::MemoryPropertyFlagBits::eHostVisible | vk::MemoryPropertyFlagBits::eHostCoherent | vk::MemoryPropertyFlagBits::eHostCached; + return vk::MemoryPropertyFlagBits::eHostVisible | + vk::MemoryPropertyFlagBits::eHostCoherent | vk::MemoryPropertyFlagBits::eHostCached; case BufferType::Stream: - return vk::MemoryPropertyFlagBits::eDeviceLocal | vk::MemoryPropertyFlagBits::eHostVisible | vk::MemoryPropertyFlagBits::eHostCoherent; + return vk::MemoryPropertyFlagBits::eDeviceLocal | vk::MemoryPropertyFlagBits::eHostVisible | + vk::MemoryPropertyFlagBits::eHostCoherent; default: UNREACHABLE_MSG("Unknown buffer type {}", type); return vk::MemoryPropertyFlagBits::eHostVisible; @@ -78,9 +80,7 @@ u32 GetMemoryType(const vk::PhysicalDeviceMemoryProperties& properties, BufferTy } // If we reach here, we couldn't find any suitable memory type - LOG_CRITICAL(Render_Vulkan, "Failed to find a suitable memory type for buffer type {}", - BufferTypeName(type)); - return 0; // Return 0 as a fallback, though this will likely cause issues + UNREACHABLE_MSG("Failed to find a suitable memory type for buffer type {}", BufferTypeName(type)); } constexpr u64 WATCHES_INITIAL_RESERVE = 0x4000;