Forks/citra
1
0
Fork 0
mirror of https://github.com/PabloMK7/citra.git synced 2025-10-31 05:40:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1309 from lioncash/render

Browse source 
video_core: Make the renderer global a unique_ptr
This commit is contained in:
bunnei 2015-12-30 11:12:30 -05:00
commit 82087672b7
2 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/video_core/video_core.cpp
View file

@ -2,7 +2,10 @@
// Licensed under GPLv2 or any later version // Licensed under GPLv2 or any later version
// Refer to the license.txt file included. // Refer to the license.txt file included.
#include <memory>
#include "common/emu_window.h" #include "common/emu_window.h"
#include "common/make_unique.h"
#include "common/logging/log.h" #include "common/logging/log.h"
#include "core/core.h" #include "core/core.h"
@ -19,7 +22,7 @@
namespace VideoCore { namespace VideoCore {
EmuWindow* g_emu_window = nullptr; ///< Frontend emulator window EmuWindow* g_emu_window = nullptr; ///< Frontend emulator window
RendererBase* g_renderer = nullptr; ///< Renderer plugin std::unique_ptr<RendererBase> g_renderer; ///< Renderer plugin
std::atomic<bool> g_hw_renderer_enabled; std::atomic<bool> g_hw_renderer_enabled;
std::atomic<bool> g_shader_jit_enabled; std::atomic<bool> g_shader_jit_enabled;
@ -29,7 +32,7 @@ void Init(EmuWindow* emu_window) {
Pica::Init(); Pica::Init();
g_emu_window = emu_window; g_emu_window = emu_window;
g_renderer = new RendererOpenGL(); g_renderer = Common::make_unique<RendererOpenGL>();
g_renderer->SetWindow(g_emu_window); g_renderer->SetWindow(g_emu_window);
g_renderer->Init(); g_renderer->Init();
@ -40,7 +43,7 @@ void Init(EmuWindow* emu_window) {
void Shutdown() { void Shutdown() {
Pica::Shutdown(); Pica::Shutdown();
delete g_renderer; g_renderer.reset();
LOG_DEBUG(Render, "shutdown OK"); LOG_DEBUG(Render, "shutdown OK");
} }

3
src/video_core/video_core.h
View file

@ -5,6 +5,7 @@
#pragma once #pragma once
#include <atomic> #include <atomic>
#include <memory>
class EmuWindow; class EmuWindow;
class RendererBase; class RendererBase;
@ -29,7 +30,7 @@ static const int kScreenBottomHeight = 240; ///< 3DS bottom screen height
// Video core renderer // Video core renderer
// --------------------- // ---------------------
extern RendererBase* g_renderer; ///< Renderer plugin extern std::unique_ptr<RendererBase> g_renderer; ///< Renderer plugin
extern EmuWindow* g_emu_window; ///< Emu window extern EmuWindow* g_emu_window; ///< Emu window
// TODO: Wrap these in a user settings struct along with any other graphics settings (often set from qt ui) // TODO: Wrap these in a user settings struct along with any other graphics settings (often set from qt ui)