mirror of
				https://github.com/PabloMK7/citra.git
				synced 2025-10-31 13:50:03 +00:00 
			
		
		
		
	citra_qt/main: Simplify OnMenuLoadFile()
We can utilize QStringList's join() function to perform all of the appending in a single function call. While we're at it, make the extension list a single translatable string and add a disambiguation comment to explain to translators what %1 actually is.
This commit is contained in:
		
							parent
							
								
									0962ab8da9
								
							
						
					
					
						commit
						7ddfce4a87
					
				
					 1 changed files with 12 additions and 12 deletions
				
			
		|  | @ -989,20 +989,20 @@ void GMainWindow::OnGameListShowList(bool show) { | |||
| }; | ||||
| 
 | ||||
| void GMainWindow::OnMenuLoadFile() { | ||||
|     QString extensions; | ||||
|     for (const auto& piece : game_list->supported_file_extensions) | ||||
|         extensions += "*." + piece + " "; | ||||
|     const QString extensions = | ||||
|         QString("*.").append(GameList::supported_file_extensions.join(" *.")); | ||||
|     const QString file_filter = tr("3DS Executable (%1);;All Files (*.*)", | ||||
|                                    "%1 is an identifier for the 3DS executable file extensions.") | ||||
|                                     .arg(extensions); | ||||
|     const QString filename = QFileDialog::getOpenFileName( | ||||
|         this, tr("Load File"), UISettings::values.roms_path, file_filter); | ||||
| 
 | ||||
|     QString file_filter = tr("3DS Executable") + " (" + extensions + ")"; | ||||
|     file_filter += ";;" + tr("All Files (*.*)"); | ||||
| 
 | ||||
|     QString filename = QFileDialog::getOpenFileName(this, tr("Load File"), | ||||
|                                                     UISettings::values.roms_path, file_filter); | ||||
|     if (!filename.isEmpty()) { | ||||
|         UISettings::values.roms_path = QFileInfo(filename).path(); | ||||
| 
 | ||||
|         BootGame(filename); | ||||
|     if (filename.isEmpty()) { | ||||
|         return; | ||||
|     } | ||||
| 
 | ||||
|     UISettings::values.roms_path = QFileInfo(filename).path(); | ||||
|     BootGame(filename); | ||||
| } | ||||
| 
 | ||||
| void GMainWindow::OnMenuInstallCIA() { | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue