mirror of
				https://github.com/PabloMK7/citra.git
				synced 2025-10-31 05:40:04 +00:00 
			
		
		
		
	kernel/svc: Do nothing if svcOutputDebugString's length is <= 0
While likely very uncommon, this sanitizes the input and does nothing in the event of the length being equal to or less than zero, avoiding constructing a std::string when there's no need to. It also avoids an out-of-memory scenario, as a negative value would wrap around to its equivalent unsigned representation in std::string's constructor. e.g. If someone was silly and a length of -1 was specified, this would make a string with a length of 0xFFFFFFFFFFFFFFFF on a 64-bit platform, which will obviously eventually fail due to the allocation being way too large.
This commit is contained in:
		
							parent
							
								
									dc863724ac
								
							
						
					
					
						commit
						5ddd382a9b
					
				
					 1 changed files with 4 additions and 0 deletions
				
			
		|  | @ -662,6 +662,10 @@ static void Break(u8 break_reason) { | ||||||
| 
 | 
 | ||||||
| /// Used to output a message on a debug hardware unit - does nothing on a retail unit
 | /// Used to output a message on a debug hardware unit - does nothing on a retail unit
 | ||||||
| static void OutputDebugString(VAddr address, int len) { | static void OutputDebugString(VAddr address, int len) { | ||||||
|  |     if (len <= 0) { | ||||||
|  |         return; | ||||||
|  |     } | ||||||
|  | 
 | ||||||
|     std::string string(len, ' '); |     std::string string(len, ' '); | ||||||
|     Memory::ReadBlock(address, string.data(), len); |     Memory::ReadBlock(address, string.data(), len); | ||||||
|     LOG_DEBUG(Debug_Emulated, "{}", string); |     LOG_DEBUG(Debug_Emulated, "{}", string); | ||||||
|  |  | ||||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue