mirror of
				https://github.com/PabloMK7/citra.git
				synced 2025-10-30 21:30:04 +00:00 
			
		
		
		
	logging: Simplify and make thread-safe
This simplifies the logging system. This also fixes some lost messages on startup. The simplification is simple. I removed unused functions and moved most things in the .h to the .cpp. I replaced the unnecessary linked list with its contents laid out as three member variables. Anything that went through the linked list now directly accesses the backends. Generic functions are replaced with those for each specific use case and there aren't many. This change increases coupling but we gain back more KISS and encapsulation. With those changes it was easy to make it thread-safe. I just removed the mutex and turned a boolean atomic. I was planning to use this thread-safety in my next PR about stacktraces. It was actually async-signal-safety at first but I ended up using a different approach. Anyway getting rid of the linked list is important for that because have the list of backends constantly changing complicates things.
This commit is contained in:
		
							parent
							
								
									8e8ca7d9d0
								
							
						
					
					
						commit
						3641b9891d
					
				
					 11 changed files with 282 additions and 325 deletions
				
			
		|  | @ -4,11 +4,13 @@ | |||
| 
 | ||||
| #include <cmath> | ||||
| #include <catch2/catch_test_macros.hpp> | ||||
| #include "common/logging/backend.h" | ||||
| #include "common/param_package.h" | ||||
| 
 | ||||
| namespace Common { | ||||
| 
 | ||||
| TEST_CASE("ParamPackage", "[common]") { | ||||
|     Common::Log::DisableLoggingInTests(); | ||||
|     ParamPackage original{ | ||||
|         {"abc", "xyz"}, | ||||
|         {"def", "42"}, | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue