Forks/citra
1
0
Fork 0
mirror of https://github.com/PabloMK7/citra.git synced 2025-10-31 22:00:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #4315 from FearlessTobi/port-1332

Browse source 
WebService: Backport review comments from yuzu-emu/yuzu#1332
This commit is contained in:
Weiyi Wang 2018-10-20 18:05:06 -04:00 • committed by GitHub
commit 11729eafe1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
21 changed files with 42 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/core/CMakeLists.txt
View file

@ -445,7 +445,8 @@ create_target_directory_groups(core)
target_link_libraries(core PUBLIC common PRIVATE audio_core network video_core)
target_link_libraries(core PUBLIC Boost::boost PRIVATE cryptopp fmt open_source_archives)
if (ENABLE_WEB_SERVICE)
target_link_libraries(core PUBLIC json-headers web_service)
target_compile_definitions(core PRIVATE -DENABLE_WEB_SERVICE)
target_link_libraries(core PRIVATE json-headers web_service)
endif()
if (ARCHITECTURE_x86_64)

2
src/core/telemetry_session.cpp
View file

@ -82,7 +82,7 @@ u64 RegenerateTelemetryId() {
return new_telemetry_id;
}
bool VerifyLogin(std::string username, std::string token) {
bool VerifyLogin(const std::string& username, const std::string& token) {
#ifdef ENABLE_WEB_SERVICE
return WebService::VerifyLogin(Settings::values.web_api_url, username, token);
#else

2
src/core/telemetry_session.h
View file

@ -56,6 +56,6 @@ u64 RegenerateTelemetryId();
* @param func A function that gets exectued when the verification is finished
* @returns Future with bool indicating whether the verification succeeded
*/
bool VerifyLogin(std::string username, std::string token);
bool VerifyLogin(const std::string& username, const std::string& token);
} // namespace Core